Replace Ecore_IMF_Input_Panel_Align with SPECIAL_TYPES mapping - #75
Merged
seungsoo47 merged 2 commits intoMay 15, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the manual definition of the Ecore_IMF_Input_Panel_Align enum from the C header file and adds it to the callback generator script's special types mapping. A review comment suggests maintaining alphabetical order for the new entry in the Python script to improve consistency and maintainability.
| 'Ecore_IMF_Input_Panel_Lang': 'some_enum', | ||
| 'Ecore_IMF_Input_Panel_Layout': 'some_enum', | ||
| 'Ecore_IMF_Input_Panel_Return_Key_Type': 'some_enum', | ||
| 'Ecore_IMF_Input_Panel_Align': 'some_enum', |
There was a problem hiding this comment.
The new entry Ecore_IMF_Input_Panel_Align should be placed in alphabetical order within the Ecore_IMF_Input_Panel_ group in the SPECIAL_TYPES dictionary to maintain consistency and improve maintainability.
JSUYA
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the same pattern used for other Ecore_IMF types (Lang, Layout, Return_Key_Type) and simplifies the type handling for callbacks.